-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer to switch to left-handed setup if right clicking "Next" #133
Offer to switch to left-handed setup if right clicking "Next" #133
Conversation
Thanks for working on this so quickly! I think we probably also need to have branches for accountsservice and settings daemon to be able to sync this setting to the new user account right? |
Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're almost there!
Something interesting I noticed is that if you right click, select right as primary, and then go back and left-click you get the dialog again. Which I think is good, because it gives us a way to revert the setting. But the copy says we've right clicked, even though we've left clicked here.
We should probably make sure to update that copy based on whether we've done a secondary click and left-handed
is active or not. Or if we can get the raw mouse button info to know which button was used. Whichever way is easier
…ght-clicking-next
@danrabbit thank you so much for your attention to detail. It's much more consistent now. |
…ght-clicking-next
I see what you're doing visually with the left-click being on the left and right-click being on the right, but I think it's deviating from the HIG to try to be too clever. It would probably be more immediately obvious to keep the suggested action in the primary (end) spot, especially when I think about localization and RTL languages… 😅 |
@cassidyjames I hope I got it right 😅 |
Closes #132
Screen_record_from_2021-12-21_15.07.51.mp4