Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer to switch to left-handed setup if right clicking "Next" #133

Merged

Conversation

meisenzahl
Copy link
Member

Closes #132

Screen_record_from_2021-12-21_15.07.51.mp4

@meisenzahl meisenzahl requested a review from a team December 21, 2021 14:13
@danirabbit
Copy link
Member

Thanks for working on this so quickly! I think we probably also need to have branches for accountsservice and settings daemon to be able to sync this setting to the new user account right?

src/Views/LanguageView.vala Outdated Show resolved Hide resolved
src/Views/LanguageView.vala Outdated Show resolved Hide resolved
meisenzahl and others added 2 commits December 22, 2021 14:57
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're almost there!

Something interesting I noticed is that if you right click, select right as primary, and then go back and left-click you get the dialog again. Which I think is good, because it gives us a way to revert the setting. But the copy says we've right clicked, even though we've left clicked here.

We should probably make sure to update that copy based on whether we've done a secondary click and left-handed is active or not. Or if we can get the raw mouse button info to know which button was used. Whichever way is easier

src/MainWindow.vala Outdated Show resolved Hide resolved
src/MainWindow.vala Outdated Show resolved Hide resolved
@meisenzahl
Copy link
Member Author

@danrabbit thank you so much for your attention to detail. It's much more consistent now.

Bildschirmfoto von 2021-12-24 07 19 40

Bildschirmfoto von 2021-12-24 07 19 56

@cassidyjames
Copy link
Contributor

I see what you're doing visually with the left-click being on the left and right-click being on the right, but I think it's deviating from the HIG to try to be too clever. It would probably be more immediately obvious to keep the suggested action in the primary (end) spot, especially when I think about localization and RTL languages… 😅

@meisenzahl
Copy link
Member Author

@cassidyjames I hope I got it right 😅

Bildschirmfoto von 2022-01-06 21 01 59

Bildschirmfoto von 2022-01-06 21 02 14

danirabbit
danirabbit previously approved these changes Jan 11, 2022
@danirabbit danirabbit merged commit 013a76b into master Jan 11, 2022
@danirabbit danirabbit deleted the offer-to-switch-to-left-handed-setup-if-right-clicking-next branch January 11, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer to switch to left-handed setup if right clicking "Next"
3 participants