-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare support for other backends #737
Conversation
instead of Distinst
bootloader_detect method
…on and ProgressView
…emon.Daemon signals
…se in a default statement.
6e40a64
to
aab202c
Compare
This reverts commit aab202c.
I successfully tested this with elementaryos-8.0-daily.20240925.iso. Steps to test this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions :)
@meisenzahl Would it be too much to ask to propose the hostname validator bit as a separate branch? I think that's probably worth its own commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I can confirm that the new DistinstBackend file is basically what was in Daemon
plus a few methods to convert from Distinst structs to our internal structs
This serves as preparation to be able to support other installer backends.