-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flatpak updates #824
base: master
Are you sure you want to change the base?
flatpak updates #824
Conversation
Allows to use GNOME Builder directly and makes it easy to copy dependencies from elsewhere.
I have been able to trigger this by changing the selected folder while it is loading.
"--talk-name=org.gnome.evolution.dataserver.Calendar8", | ||
"--talk-name=org.gnome.evolution.dataserver.Sources5", | ||
"--talk-name=org.gnome.evolution.dataserver.UserPrompter0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think mail uses the Calendar and UserPrompter Services. don't need to expose them to the sandbox.
@@ -50,7 +53,7 @@ | |||
{ | |||
"type": "git", | |||
"url": "https://gitlab.gnome.org/GNOME/evolution-data-server.git", | |||
"tag": "3.40.2" | |||
"branch": "3.46.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a tag, not a branch. Also, maybe it's better to keep the version here and in the OS in sync since we aren't really using the server from the sandbox.
"type": "archive", | ||
"url": "https://github.com/libical/libical/releases/download/v3.0.16/libical-3.0.16.tar.gz", | ||
"sha256": "b44705dd71ca4538c86fb16248483ab4b48978524fb1da5097bd76aa2e0f0c33" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to prefer the archive over the git repo? if so, wouldn't be better to use archive for all dependencies?
Also, there's a extra space before the close brace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flatpak is way more efficient when dealing with archives than git repositories (it only has to look at if the file is newer on the server before downloading it)
@tintou is this branch still relevant? If so, can you resolve conflicts |
Update flatpak and add a small fix
Use rebase to merge it.