Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageList: Rewrite headers #893

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 17, 2023

Makes expanded headers much more compact and makes it much easier to navigate conversations with changing subjects

  • Use CSS to set padding and margins
  • Show a subject header in the message list only when it changes instead in every message
  • Slightly reduce the size of Avatars
  • Don't show the "From:" label. Other fields like to, cc, bcc etc need disambiguation, but I think this is fairly clear that this first line is the sender
  • Put all the actions in a row. This prevents things from moving around when messages have attachments etc

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like how much space this takes now. IMHO current design works great, why change it? Today I've seen people discussing this change in one of the elementary OS groups in Telegram and seems like people like compact design more.

However I like some changes: Hidden "From" label and actions in a row.

@danirabbit
Copy link
Member Author

@lenemter okay, I'll split that out! I would like to find a way to not repeat the subject line in every header and handle changing subjects more obviously but we can do things in stages and try to preserve the more compact design as well :)

@danirabbit
Copy link
Member Author

Hey @lenemter, I was able to get the overlapping back in there with some funky selectors, we still get separate headers for conversations where the subject changes (See the screenshot at the top I updated), and for single-subject conversations you can see the message headers are much more compact with no repeating subject line, and the datetime is centered vertically for the overlapped messages.

Screenshot from 2023-05-18 14 39 31
Screenshot from 2023-05-18 14 38 51

However, by overlapping again, we do lose the ability to see if a collapsed message was starred or has an attachment, so that seems problematic to me. I think from a perspective of doing the least hacky stuff, changing the header the least when collapsed, having the conversation list be usable at small window widths for tiling and mobile, and making sure all the information is visible for collapsed messages that overlapping is kind of a huge problem. Since it's in a scrolling list, I'm not sure using up vertical space is a huge issue.

@lenemter

This comment was marked as resolved.

@lenemter

This comment was marked as resolved.

@lenemter
Copy link
Member

Sorry, just updated my Mail. Seems like the issue is present in master as well. Probably introduced by recent PRs.

@leolost2605
Copy link
Member

Probably with #888 then. Can you maybe open an issue with a clip or go into more detail what is slow? Like does it freeze or does it just not get trashed or similar stuff?

@danirabbit danirabbit marked this pull request as draft May 23, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants