Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force disabling webkit compositing mode #982

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Force disabling webkit compositing mode #982

merged 1 commit into from
Mar 27, 2024

Conversation

leolost2605
Copy link
Member

This fixes #950 which currently renders mail pretty much unusable and is an alternative to #973 that doesn't change the current design. I think it might be worth considering merging and releasing this or at least something similar to #973 since OS8 is still a bit away and in my testing it's not even yet fixed there (neither GTK3 nor GTK4) although some bug reports from webkit suggest it is 🤷

As per webkit documentation this

Force[s] Accelerated Compositing mode to be always off

While this is of course not an optimal solution I think it should be fine for the mail messages usecase.

@leolost2605 leolost2605 requested a review from a team March 25, 2024 22:32
@jeremypw
Copy link

This looks like a much better solution, in principle. I am getting a crash when running on OS8 (Early Access) though:

(gdb) bt
#0  0x00007ffff7ec00ef in g_log_structured_array () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007ffff7ec03dc in g_log_default_handler () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007ffff7ec0680 in g_logv () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007ffff7ec0963 in g_log () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x00007ffff32fb9f1 in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#5  0x00007ffff32f900a in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#6  0x00007ffff32fac9e in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#7  0x00007ffff311769a in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#8  0x00007ffff31f5f6a in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#9  0x00007ffff31f8a15 in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#10 0x00007ffff31f9096 in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#11 0x00007ffff31b31ff in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#12 0x00007ffff31b65df in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
--Type <RET> for more, q to quit, c to continue without paging--
#13 0x00007ffff31b6669 in ??? () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#14 0x00007ffff328ed58 in webkit_web_view_load_html () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.1.so.0
#15 0x000055555559b7c6 in mail_web_view_load_html
    (self=0x555555d6aec0, body=0x555555df1270 "<html xmlns:v=\"urn:schemas-microsoft-com:vml\" xmlns:o=\"urn:schemas-microsoft-com:office:office\" xmlns:w=\"urn:schemas-microsoft-com:office:word\" xmlns:m=\"http://schemas.microsoft.com/office/2004/12/omm"...) at ../src/WebView.vala:138
#16 0x00005555555eef6c in mail_message_list_item_open_message_co (_data_=0x555555dac950) at ../src/MessageList/MessageListItem.vala:570
#17 0x00005555555eeda8 in mail_message_list_item_open_message_ready (source_object=0x555555d27ea0, _res_=0x555555dba5a0, _user_data_=0x555555dac950)
    at ../src/MessageList/MessageListItem.vala:564
#18 0x00007ffff71e874b in ??? () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#19 0x00007ffff71ec6a3 in ??? () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#20 0x00005555555f002e in mail_message_list_item_parse_mime_content_co (_data_=0x555555a7a770) at ../src/MessageList/MessageListItem.vala:589
#21 0x00005555555ef3bd in mail_message_list_item_parse_mime_content_ready (source_object=0x555555d27ea0, _res_=0x555555da5f90, _user_data_=0x555555a7a770)
    at ../src/MessageList/MessageListItem.vala:596
#22 0x00007ffff71e874b in ??? () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#23 0x00007ffff71ec6a3 in ??? () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#24 0x00005555555f0935 in mail_message_list_item_handle_text_mime_co (_data_=0x555555b93230) at ../src/MessageList/MessageListItem.vala:618
#25 0x00005555555f02c6 in mail_message_list_item_handle_text_mime_ready (source_object=0x7fff9c372ce0, _res_=0x555555dbd8d0, _user_data_=0x555555b93230)
    at ../src/MessageList/MessageListItem.vala:623
#26 0x00007ffff71e874b in ??? () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#27 0x00007ffff71e8785 in ??? () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#28 0x00007ffff7ebb49e in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#29 0x00007ffff7f1a727 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#30 0x00007ffff7ebaa63 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#31 0x00007ffff721e82d in g_application_run () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#32 0x000055555557d78d in _vala_main (args=0x7fffffffdcf8, args_length1=1) at ../src/Application.vala:239
#33 0x000055555557d7d4 in main (argc=1, argv=0x7fffffffdcf8) at ../src/Application.vala:236

I'll try on OS7.1 later.

@jeremypw
Copy link

jeremypw commented Mar 26, 2024 •
edited
Loading

Seems to work OK on OS7.1, the only noticeable difference being a lag in displaying the contents of the message, which is tolerable under the circumstances.

@jeremypw
Copy link

Not sure whether OS8 issue needs fixing before merging though. Will there be another OS7.1 release?

@jeremypw jeremypw requested a review from danirabbit March 27, 2024 15:55
@danirabbit
Copy link
Member

Sounds like it’s worth releasing another version of Mail for OS 7 and we can worry about OS 8 specific issues after that :)

@danirabbit danirabbit merged commit fdad9c3 into master Mar 27, 2024
3 checks passed
@danirabbit danirabbit deleted the leolost/make-it-usable-again branch March 27, 2024 15:57
@leolost2605 leolost2605 mentioned this pull request Mar 29, 2024
Open
@danirabbit danirabbit mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

@danirabbit danirabbit Awaiting requested review from danirabbit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Many mails flash to white after opening
3 participants
@leolost2605 @jeremypw @danirabbit