Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure all scripts exit on failure. #285

Closed
wants to merge 1 commit into from
Closed

make sure all scripts exit on failure. #285

wants to merge 1 commit into from

Conversation

kgrubb
Copy link
Collaborator

@kgrubb kgrubb commented Jan 22, 2020

this just adds some set -e options in some of the shell scripts so that they exit on failure.

@kgrubb kgrubb added the Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Jan 22, 2020
@kgrubb kgrubb requested a review from davidmhewitt January 22, 2020 18:40
davidmhewitt
davidmhewitt reviewed Jan 22, 2020
View reviewed changes
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get build.sh as well?

@kgrubb
Copy link
Collaborator Author

kgrubb commented Jan 23, 2020

Closing in favor of #286

@kgrubb kgrubb closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmhewitt davidmhewitt davidmhewitt left review comments

Assignees
No one assigned
Labels
Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgrubb @davidmhewitt