Allow live-build to remove protected pkgs in iso bootloader stage #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintou
approved these changes
Aug 4, 2021
|
Related pr in live-build, for record keeping/paper trail: https://salsa.debian.org/live-team/live-build/-/merge_requests/255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
I've tested that this is enough to get the RC image building locally.
The
shim-signedpackage from Ubuntu was updated 2 days ago to include some flags in the debian control file to prevent accidental removal of the package. During the phase of the build that was failing, live-build temporarily installs grub and the shim to make the boot sector of the iso image, and then tries to remove them again afterwards to clean up after itself. Since Ubuntu updatedshim-signed, it wasn't able to remove it anymore, without an additional flag.I'll get this proposed as a patch upstream and then we can add a comment in here with a link to the PR. But I've proposed here first so we can at least get going with building an RC image.