Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow reordering. #651

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix slow reordering. #651

wants to merge 1 commit into from

Conversation

vjr
Copy link
Member

@vjr vjr commented Oct 1, 2021

Fixes #649

@vjr
Copy link
Member Author

vjr commented Oct 1, 2021 •
edited
Loading

This is only a potential fix because I've not tested it thoroughly for any regressions or side effects.

@vjr vjr mentioned this pull request Oct 1, 2021
Open
@vjr vjr requested a review from a team October 1, 2021 18:12
@asonix
Copy link
Contributor

asonix commented Oct 1, 2021

This doesn't seem to change the time it takes for the reorder to complete on my laptop. I tried comparing this branch to master and didn't notice a difference

@vjr
Copy link
Member Author

vjr commented Oct 1, 2021

OK, I'll try looking into this some more...

@vjr vjr marked this pull request as draft October 1, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Very slow to open due to reorder of massive tree
2 participants
@vjr @asonix