Updates for ExternalWindow #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Gdk.Window.set_transient_for()` was removed on Gtk4, so we need to use the x11 methods directly.
|
Interesting; I also tried to simply set use In any case: The X11 implementation still works and overall code looks good to me, thank you @Marukesu! Unfortunately I don't have Wayland to test available, so I'm pinging @danrabbit for additional review and/or merging. |
marbetschar
reviewed
Jun 4, 2022
marbetschar
added a commit
that referenced
this pull request
Jun 6, 2022
|
@danrabbit any chance we can get this merged in? Code LGTM |
tintou
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add wayland support for parenting and adapt the ExternalWindowX11 to Gtk4 removals, should made the gtk4 diff smaller.