Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to GTK4 #240

Merged
merged 12 commits into from
Aug 23, 2024
Merged

Port to GTK4 #240

merged 12 commits into from
Aug 23, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 6, 2022 •
edited
Loading

Fixes #234

@treppenwitz03 treppenwitz03 mentioned this pull request Feb 9, 2022
Merged
@danirabbit danirabbit marked this pull request as ready for review August 6, 2024 20:24
@danirabbit danirabbit requested a review from a team August 6, 2024 20:24
@danirabbit danirabbit changed the title Initial GTK4 port Port to GTK4 Aug 6, 2024
zeebok
zeebok approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have the one question and the conflicts to sort out but looks good either way

src/ScreenshotWindow.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit enabled auto-merge (squash) August 23, 2024 14:26
@danirabbit danirabbit merged commit 8636e92 into master Aug 23, 2024
3 checks passed
@danirabbit danirabbit deleted the gtk4 branch August 23, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
Conflicts
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port Screenshot to GTK4
3 participants
@danirabbit @zeebok @treppenwitz03