ScreenshotWindow: GTK 4 prep #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
approved these changes
Nov 12, 2023
| @@ -195,6 +195,7 @@ public class Screenshot.SaveDialog : Granite.Dialog { | |||
| content.add (format_cmb); | |||
| content.add (location_label); | |||
| content.add (location_button); | |||
| content.show_all (); | |||
There was a problem hiding this comment.
Does GTK4 still have show_all for some things?
There was a problem hiding this comment.
@zeebok It doesn't, but we still need it in GTK 3 to show things packed into the dialog content area. I think dialog.run contains a show_all so we need to temporarily add it here when replacing with dialog.present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show_allorno_show_allso change the way we choose not to show redact option. Also present dialog not show_all