SuccessView: Make primary label format consistent #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
added
the
Bitesize
There was a problem hiding this comment.
Ah so my comment in Slack was that I didn't love that this was a bit more passive/distanced, like, "Foo App was installed all by itself, I have no idea how it happened!" versus "I installed Foo App". The fallback text is a bit more passive just because it felt stilted to say, "Installed the app".
That said, @danrabbit and I both didn't feel very strongly either way. 😛
|
Super scientific polls for an added data point: |
|
Another phrasing someone brought up on Twitter is |
Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>
cassidyjames
added a commit
to elementary/appcenter
that referenced
this pull request
Dec 9, 2020
danirabbit
pushed a commit
to elementary/appcenter
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking about it, I think I like the way this looks better: