Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle flatpak+https scheme #170

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Handle flatpak+https scheme #170

merged 4 commits into from
Jul 31, 2024
+112 −72

Conversation

meisenzahl
Copy link
Member

Closes #169

@meisenzahl
Copy link
Member Author

I use GLib.File.copy to download the FlatpakRef. This was the easiest way without adding new external dependencies.

@meisenzahl meisenzahl assigned tintou and unassigned tintou Jul 29, 2024
@meisenzahl meisenzahl requested a review from tintou July 29, 2024 10:34
danirabbit
danirabbit requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, just one request to make sure we throw an error dialog or I can't remember if Sideload has an error view. Something that the user can see the error

src/Application.vala Outdated Show resolved Hide resolved
@meisenzahl
Copy link
Member Author

In order to be able to display an error to a user in the ErrorView, I unfortunately had to move the logic for parsing the Flatpak file to the MainWindow. @danirabbit let me know what you think.

danirabbit
danirabbit approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice. I didn't realize that so many of these other errors were silent as well. Thanks for fixing those! Seems like everything is working as expected. Good job!

@danirabbit danirabbit merged commit 96e57ff into main Jul 31, 2024
4 checks passed
@danirabbit danirabbit deleted the handle-flatpak+https-scheme branch July 31, 2024 18:44
@razzeee razzeee mentioned this pull request Jan 6, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

@tintou tintou Awaiting requested review from tintou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handke flatpak+https scheme
3 participants
@meisenzahl @danirabbit @tintou