Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play nicely with other overrides #168

Merged
merged 7 commits into from
Sep 23, 2021

Conversation

jhaygood86
Copy link
Contributor

@jhaygood86 jhaygood86 commented Sep 16, 2021

Fixes #155

  1. Reset overrides ONLY overrides permissions controlled by this plug
  2. Saving new overrides merges the new values into the existing files in the file

1. Reset overrides ONLY overrides permissions controlled by this plug
2. Saving new overrides merges the new values into the existing files in the file
@cassidyjames cassidyjames requested a review from a team September 16, 2021 04:45
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice work! This is really close, but I am noticing an issue where it looks like it's putting together strings with ; in the middle instead of at the end.

For example:

Use flatpak override to add a custom filesystem permission. See that the contents of the overrides file are:

[Context]
filesystems=/path/to/directory;

Toggle a permission off. (I used network). Notice that the the contents are now:

[Context]
filesystems=;/path/to/directory
shared=network

@jhaygood86
Copy link
Contributor Author

I see what's going on.

[Context]
filesystems=/path/to/directory;

is interpreted as 2 values, one of which is a zero length string. Easy fix though.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@danirabbit danirabbit merged commit b6903cb into elementary:master Sep 23, 2021
@jhaygood86 jhaygood86 deleted the fix-overwriting-overrides branch September 23, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom directory access gets overwritten when opening Applications plug
2 participants