Fix wingpanel bluetooth indicator settings fight #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
approved these changes
Apr 8, 2023
There was a problem hiding this comment.
Code looks good. Tested with elementary/wingpanel-indicator-bluetooth#195. Fixes the issue for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #201
This stops the wingpanel indicator overriding the plug and turning Bluetooth back on when switched off in the plug. The plug no longer changes the wingpanel settings. Instead it only interacts with the global state and turns the Bluetooth adaptor(s) on and off. It is left to the wingpanel indicator to pick up the change and make any necessary changes to the UI and settings.
A related PR to the wingpanel will be pushed to completely synchronise the settings, plug and indicator, but this is not required for this PR to work.
An unneeded Idle is removed and an unnecessary public scope reduced to make the code more predicatble.
Suspend/reawaken still works as expected.