SearchView: only invalidate when search isn't empty (#327)

elementary · Oct 22, 2024 · 161154a · 161154a
1 parent be7f38a
commit 161154a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/data/settings.appdata.xml.in b/data/settings.appdata.xml.in
@@ -45,6 +45,9 @@
           <li>Updated translations</li>
         </ul>
       </description>
+      <issues>
+        <issue url="https://github.com/elementary/switchboard/issues/182">Search returns alphabetically sorted list after clicking on a search result</issue>
+      </issues>
     </release>
 
     <release version="8.0.0" date="2024-05-21" urgency="medium">

diff --git a/src/SearchView.vala b/src/SearchView.vala
@@ -48,16 +48,20 @@ public class Switchboard.SearchView : Gtk.Box {
 
         search_entry.search_changed.connect (() => {
             alert_view.title = _("No Results for “%s”").printf (search_entry.text);
-            listbox.invalidate_filter ();
-            listbox.invalidate_sort ();
-            listbox.select_row (null);
+
+            if (search_entry.text.length > 0) {
+                listbox.invalidate_filter ();
+                listbox.invalidate_sort ();
+                listbox.select_row (null);
+            }
         });
 
         listbox.row_activated.connect ((row) => {
             app.load_setting_path (
                 ((SearchRow) row).uri.replace ("settings://", ""),
                 Switchboard.PlugsManager.get_default ()
             );
+
             search_entry.text = "";
         });
     }