Load only non-completed tasks by default #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash experienced by users with a lot of tasks per list (#294). The root cause there is, that we are loading all tasks per default - even the completed ones.
This PR mitigates the situation by only loading the non-completed tasks by default. If the user enables "Show Completed", then a new query is executed which also retrieves the completed tasks.
Please note, loading the completed tasks as well would still lead to the crash. But in Gtk3 there is no builtin way to mitigate this, because Gtk.ListBox simply renders whatever we throw at it - instead of only doing so for the visible area only. A more elegant fix would be to use Gtk4's ListView - but at the time of writing this is not possible, since we can't pack Tasks as Flatpak right now.
Therefore this strategy at least solves the immediate problem and we can refactor this later on.