Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Duplicated tasks in Scheduled #364

Closed
wants to merge 2 commits into from
Closed

Fixed Duplicated tasks in Scheduled #364

wants to merge 2 commits into from

Conversation

Claudio-code
Copy link
Contributor

@Claudio-code Claudio-code commented Jun 22, 2023

I tried fix it issue #359

For what i tested even removing this code all task updates are still reflected in the scheduled session.

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how it's supposed to be done. All the code you removed is responsible for handling cases when new task lists are added or removed and it adds tracker of the list for them. Removing this code introduces some bugs, such as when user creates a new task list and adds tasks to it, these tasks will not appear in scheduled view.

The real issue here is in remove_view method. It doesn't properly destroy tasks. You can try to look into this :)

@Claudio-code
Copy link
Contributor Author

I understand I close the pr try another way thanks for the context

@Claudio-code Claudio-code deleted the fix-duplicated-tasks branch June 22, 2023 15:30
@Claudio-code
Copy link
Contributor Author

@lenemter now i achieved found solution #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants