-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accent color #138
Accent color #138
Conversation
The accent color is now set as |
@meisenzahl I'm not super familiar with how XMP in EXIF works, but it sounds like it would be good to RDNN prefix it to avoid potential collisions? |
@cassidyjames Yes, exactly. Feel free to suggest what the attribute should be called. |
@meisenzahl io.elementary.AccentColor seems fine to me. Could we ensure we're matching this mapping, though? I think we're also generally moving to only use the cutesy food names in user strings and just use more standard color names anywhere for developers. |
@cassidyjames I'll take a look to see if we can ensure we're matching this mapping. What do you think about a command line tool that makes sure that when you add a new image attributes like author and accent color are set? I can refactor to use the following colors:
|
@meisenzahl I would be open to is as long as it's simple enough to use and maintain. :) |
@cassidyjames ready for review. I hope I have set all colors correctly now :) |
@meisenzahl okay I talked this through with Dan to make sure this was a good approach, and we agree EXIF seems like a good fit. But what's the need for the command-line app? It seems that we have to copy-paste some commands from the README either way, so this seems like it might be over-complicated compared to just using exiftool directly. |
@cassidyjames with the command line application you can set the EXIF information, but you can also lint the files. The cli tool also checks if the provided accent color is a valid value. I was not able to use |
@meisenzahl gotcha. I think for now, let's split the command line tool off into its own branch so we can discuss/debate it there—but I'm fine with the inclusion of the EXIF data here. |
I have cleaned up the PR so far. However, I am not sure how to write the @cassidyjames shall we discuss how to proceed with adding and verifying the metadata in #140? |
Goes with elementary/settings-daemon#25