Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume levelbar inline #267

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add volume levelbar inline #267

wants to merge 1 commit into from

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Dec 29, 2023 •
edited
Loading

Alternative design solution for #13. Instead of showing volume change confirmations as a notification, temporarily show an inline levelbar.

Screenshot from 2023-12-29 12 43 19

This is just a proof of concept. Todo:

  • Support levelbars in the panel's css so we're not duplicating styles
  • Don't show the levelbar when the panel first starts
  • hide the levelbar when the indicator is open
  • Don't show the levelbar when sound is changed via system settings
  • Don't show volume change confirmations as a notification
  • handle mic volume changes?
  • volume blocking styles?
  • insensitive style for mute?
  • stay revealed when hovered?
  • Test screen reader behavior

@danirabbit danirabbit mentioned this pull request Dec 29, 2023
Open
@lenemter lenemter mentioned this pull request Dec 30, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danirabbit