Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matplotlib version #482

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

uremes
Copy link
Contributor

@uremes uremes commented May 27, 2024

Summary:

restrict matplotlib version to < 3.9 because GPy usesmatplotlib.cm.get_cmap which is removed in 3.9.0.

Please make sure

  • You have read contribution guidelines
  • You have updated CHANGELOG.rst
  • You have listed the copyright holder for the work you are submitting (see next section)

If your contribution adds, removes or somehow changes the functional behavior of the package, please check that

  • You have included or updated all the relevant documentation, including docstrings
  • You have added appropriate functional and unit tests to ensure the new features behave as expected
  • You have run make lint, make docs and make test

and the proposed changes pass all unit tests (check step 6 of CONTRIBUTING.rst for details)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@uremes uremes requested a review from hpesonen May 27, 2024 23:28
@hpesonen hpesonen merged commit 40d2479 into elfi-dev:dev May 30, 2024
4 checks passed
@uremes uremes deleted the fix_matplotlib_version branch June 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants