iterm2 rich keyboard protocol support #1610
Merged
+346
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or this (as right Command is used for iTerm2's hotkeys)
…orkaround: turn 1337 mode off on cmd press and turn it back on after 2 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: cmd+v shortcut seems not to work in rich kb mode, so we disable this mode for 2 seconds if cmd key press is caught. also right alt is mapped to right control as there is no right control on some mac keyboards, and right_cmd+number hotkeys are used by iterm2 itself. also sscanf works ok here even if some parts of sequence are omitted.