Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panicking Proxy's methods should print the source location of a caller #75

Closed
loyd opened this issue Jun 24, 2022 · 0 comments
Closed

Panicking Proxy's methods should print the source location of a caller #75

loyd opened this issue Jun 24, 2022 · 0 comments
Labels
A-test Area: The elfo-test crate. C-feature-accepted Category: A feature request that has been accepted pending implementation.

Comments

@loyd
Copy link
Collaborator

loyd commented Jun 24, 2022

E.g. if Proxy::recv() is timed out, a message is printed with the location pointing to elfo-test/src/proxy.rs instead of the location of a caller.

We cannot just use the #[track_caller] attribute on async fn (rust-lang/rust#78840). However, it's possible to get Location outside an async block and then add to a panic message.
@loyd loyd added C-feature-accepted Category: A feature request that has been accepted pending implementation. A-test Area: The elfo-test crate. labels Jun 24, 2022
@loyd loyd closed this as completed in 6c57356 Jun 24, 2022
Leonqn pushed a commit to Leonqn/elfo that referenced this issue Jun 24, 2022
@loyd @Leonqn
fix(test/proxy): add the location of a caller to panics
d2d2d18 
Closes elfo-rs#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-test Area: The elfo-test crate. C-feature-accepted Category: A feature request that has been accepted pending implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loyd