-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): the restarting policy can be overridden via configuration for each actor. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39a6943
to
7e8b100
Compare
loyd
requested changes
Dec 15, 2023
loyd
reviewed
Dec 15, 2023
loyd
reviewed
Dec 15, 2023
loyd
reviewed
Dec 15, 2023
loyd
reviewed
Dec 15, 2023
6191d9f
to
e164220
Compare
b35fedb
to
742d7c3
Compare
4157555
to
c48a0d4
Compare
loyd
reviewed
Dec 20, 2023
loyd
reviewed
Dec 20, 2023
1c2bdba
to
7dc7296
Compare
loyd
reviewed
Dec 20, 2023
|
||
use crate::ActorStatus; | ||
|
||
/// The behaviour on actor termination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like TerminationPolicy
loyd
approved these changes
Dec 20, 2023
3178ea5
to
abe5fc7
Compare
… for each actor. `RestartParams` have been added for `RestartPolicy::always(..)` and `RestartPolicy::on_failure(..)`. The linear backoff has been replaced with an exponential approach, with a configurable limit for restarts. BREAKING CHANGE: The default RestartPolicy is set to `RestartPolicy::never()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestartParams
have been added forRestartPolicy::always(..)
andRestartPolicy::on_failure(..)
.The linear backoff has been replaced with an exponential approach, with a configurable limit for restarts.
BREAKING CHANGE: The default RestartPolicy is set to
RestartPolicy::never()
,RestartPolicy::always
andRestartPolicy::on_failure
have args .