feat: enable serialization of enumerable and actions #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enumerable
to include atoJSON
andtoString
implementation, allowing enumerables to be serialized.ActionContext
,KeyAction
, andDialAction
to include getters when serializing.Motive
When logging the
streamDeck.actions
, orthis.actions
within an action, nothing is logged. WithEnumerable
yielding results lazily, JavaScript does not evaluate the collection when formatting the logs as part of theJSON.stringify
call. To resolve this, we can implementtoJSON
andtoString
functions onEnumerable
.With the aforementioned functions implemented, we now have actions logging, however the result looks something like this:
This is caused by the
KeyAction
,DialAction
, andActionContext
classes relying on getters for immutability. WithtoJSON
implemented on these classes, we finally see a meaningful log entry: