Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving towards TS #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

moving towards TS #43

wants to merge 5 commits into from

Conversation

firstdorsal
Copy link

I dont expect you to merge this but i thought i would share it with you.

  • replaced let with const where possible
  • arrow functions
  • compile directly from ts
  • make it usable in deno
  • still works

@elgs
Copy link
Owner

elgs commented Feb 2, 2022

Thanks for the PR.

  • replaced let with const where possible

This project started before let was introduced to js, then I replaced most, if not all vars to lets. Yes, they should be changed to const.

  • arrow functions

I don't have any preference for this. Actually there is subtle difference for the reference of this for a function vs. an arrow function. But in this case, they should be the same.

  • compile directly from ts

I try to avoid compilation for a small single js file project like this. But this is purely opinionated. You could be totally right and I be totally wrong.

  • make it usable in deno

I thought the current code works with Deno, or does it not?

  • still works

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants