Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix; Fix error: ImportError #39

Closed
wants to merge 1 commit into from

Conversation

mooujarrar
Copy link

While attempting to work with the project with Conda, the following error ImportError: attempted relative import with no known parent package when working with conda was shown, I've made a fix for it.

It seems to be working fine now.

@eli64s eli64s force-pushed the main branch 23 times, most recently from 452b314 to 60dc0f5 Compare August 29, 2023 23:32
@rachadele
Copy link

these fixes worked get the script running for me! also needed to pip install readmeai after making them

@eli64s
Copy link
Owner

eli64s commented Sep 18, 2023

Hi @mooujarrar,

Firstly, thanks for taking the time to contribute to the readme-ai project. The effort is much appreciated.

After reviewing your pull request aimed at solving issue #37, there are a couple of points that prevent merging to main:

  1. Relative Imports: As the readmeai package is designed for distribution via PyPI, we follow a convention of utilizing relative imports for intra-package modules. Your pull request currently employs absolute imports, which may lead to issues for end-users after package installation.
  2. Issue OSError: [Errno 36] File name too long (docker) #37: This is a great catch and start to correcting this bug, however, there was an underlying issue in the preprocess.py script causing the error.

I am closing pull request, but recognized your efforts in the latest version release notes and CHANGELOG.md.

Thanks again for this contribution, and hope you can contribute to readme-ai in the future!

Best,
Eli


@eli64s eli64s closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants