Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update @symfony/webpack-encore to v5 #839

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 30, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@symfony/webpack-encore ^4.0.0 -> ^5.0.0 age adoption passing confidence

Release Notes

symfony/webpack-encore (@​symfony/webpack-encore)

v5.0.0

Compare Source

This is a new major version that contains several backwards-compatibility breaks.

Features
  • #​1344 Add options configuration callback to Encore.enableReactPreset() (@​Kocal)

  • #​1345 Add support for integrity hashes when asset names contain a query string (@​Kocal)

BC Breaks

The dev-server options have changed between versions 4 and 5, see the official migration guide to v5.
For example:

// With webpack-dev-server 4:
Encore.configureDevServerOptions((options) => {
   options.https = {
     ca: "./path/to/server.pem",
     pfx: "./path/to/server.pfx",
     key: "./path/to/server.key",
     cert: "./path/to/server.crt",
     passphrase: "webpack-dev-server",
     requestCert: true,
   };
});

// With webpack-dev-server 5 (now):
Encore.configureDevServerOptions((options) => {
   options.server = {
      type: 'https',
      options: {
         ca: "./path/to/server.pem",
         pfx: "./path/to/server.pfx",
         key: "./path/to/server.key",
         cert: "./path/to/server.crt",
         passphrase: "webpack-dev-server",
         requestCert: true,
      }
   };
});

The webpack-dev-server package is now an optional peer dependency.
It has been removed because some projects may not use it, and it was installing a bunch of unnecessary dependencies.

Removing the webpack-dev-server dependency from Encore reduces the number of dependencies from 626 to 295 (-331!),
it helps to reduce the size of the node_modules directory and the number of possible vulnerabilities.

To use the webpack-dev-server again, you need to install it manually:

npm install webpack-dev-server --save-dev

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Updates project dependencies label Sep 30, 2024
Copy link

codeclimate bot commented Sep 30, 2024

Code Climate has analyzed commit 1d489eb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.9% (0.0% change).

View more on Code Climate.

@coveralls
Copy link
Collaborator

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11173346462

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.95%

Totals Coverage Status
Change from base Build 11173336797: 0.0%
Covered Lines: 471
Relevant Lines: 476

💛 - Coveralls

@renovate renovate bot force-pushed the renovate/symfony-webpack-encore-5.x branch 7 times, most recently from fa954e6 to 11cb38c Compare October 3, 2024 07:22
| datasource | package                 | from  | to    |
| ---------- | ----------------------- | ----- | ----- |
| npm        | @symfony/webpack-encore | 4.7.0 | 5.0.1 |
@renovate renovate bot force-pushed the renovate/symfony-webpack-encore-5.x branch from 11cb38c to 1d489eb Compare October 4, 2024 03:13
@eliashaeussler eliashaeussler merged commit 022b3fd into main Oct 4, 2024
13 checks passed
@eliashaeussler eliashaeussler deleted the renovate/symfony-webpack-encore-5.x branch October 4, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants