feat: refactor for jpms support #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
added
java
github-actions
bot
added
module:server
sgammon
added
module:graalvm
sgammon
commented
Jul 30, 2023
| @@ -1,4 +1,4 @@ | |||
| registry=https://npm.pkg.st/ | |||
| #registry=https://npm.pkg.st/ | |||
| "@babel/code-frame@^7.0.0", "@babel/code-frame@^7.10.4", "@babel/code-frame@^7.18.6", "@babel/code-frame@^7.21.4": | ||
| version "7.21.4" | ||
| resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.21.4.tgz#d0fa9e4413aca81f2b23b9442797bda1826edb39" | ||
| integrity sha512-LYvhNKfwWSPpocw8GI7gpK2nq3HSDuEPC/uSYaALSJu9xjsalaaYFOq0Pwt5KmVqwEbZlDu81aLXwBOmD/Fv9g== |
| @@ -0,0 +1,22 @@ | |||
| package elide.annotations.base | |||
There was a problem hiding this comment.
breaking: these annotations are moving to avoid split packages
Comment on lines
-170
to
+168
| ) | ||
| //configureJava9ModuleInfo(project) |
| @@ -1,4 +1,4 @@ | |||
| package elide.annotations.core | |||
| package elide.vm.annotations | |||
There was a problem hiding this comment.
breaking: the Polyglot annotation is moving. again, to avoid split packages
Comment on lines
+193
to
+201
| // Unused dependencies: | ||
| // implementation(libs.lmax.disruptor.proxy) | ||
| // implementation(libs.brotli) | ||
| // implementation(libs.micronaut.inject.java) | ||
| // implementation(libs.micronaut.cache.core) | ||
| // implementation(libs.micronaut.cache.caffeine) | ||
| // implementation(libs.lz4) | ||
| // implementation(libs.flatbuffers.java.core) | ||
| // implementation(libs.kotlinx.coroutines.slf4j) |
There was a problem hiding this comment.
all unused. junit was making it in somehow too.
| @@ -1,9 +1,9 @@ | |||
| package elide.annotations | |||
| package elide.core.annotations | |||
There was a problem hiding this comment.
these are moving to avoid split packages but are largely unused outside of core library code
|
|
||
| /** | ||
| * Annotate a member or function as inlined. | ||
| * | ||
| * This annotation is currently stubbed directly to Kotlin's `JvmInline` annotation, but may be expanded or replaced in | ||
| * the future. | ||
| */ | ||
| public actual typealias Inline = JvmInline | ||
| public expect annotation class Inline() |
| @@ -125,32 +125,39 @@ import org.graalvm.polyglot.Engine as VMEngine | |||
| description = ["Specify language by name. Options: \${COMPLETION-CANDIDATES}."], | |||
| defaultValue = "JS", | |||
| ) | |||
| internal var language: GuestLanguage = GuestLanguage.JS | |||
| internal var language: EnumSet<GuestLanguage> = EnumSet.of(GuestLanguage.JS) | |||
There was a problem hiding this comment.
dropping bundler support (temp)
sgammon
commented
Jul 30, 2023
packages/graalvm/api/graalvm.api
Outdated
| @@ -129,7 +128,6 @@ public final class elide/runtime/gvm/InvocationMode : java/lang/Enum { | |||
| public static final field ASYNC Lelide/runtime/gvm/InvocationMode; | |||
| public static final field STREAMING Lelide/runtime/gvm/InvocationMode; | |||
| public static final field SYNC Lelide/runtime/gvm/InvocationMode; | |||
| public static fun getEntries ()Lkotlin/enums/EnumEntries; | |||
There was a problem hiding this comment.
not really sure why these are getting removed
- feat: introduce module configurations for most packages - chore: refactor split-package modules (breaking) - chore: update all use-sites for `Polyglot` etc - chore: remove stray pnpm lock in `tools/scripts` Caution: This commit was restored and needs to be reviewed with care before merging. Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
- fix: don't link against graalvm modules (use runtime) - chore: general cleanup of warnings in js runtime Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
|
merging because test failure will be fixed by next pr, and because jpms is working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Polyglotetctools/scriptsCaution: This commit was restored and needs to be reviewed with care before merging.
Changelog
Coming soon.