Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Sicko Mode (Loom) #449

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Feature: Sicko Mode (Loom) #449

merged 1 commit into from
Oct 5, 2023

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Oct 5, 2023

Ready for review Powered by Pull Request Badge

Summary

Enable virtual threads in Elide.

Changelog

  • feat: enable VIRTUAL threads in micronaut executors
  • feat: enable ofVirtual threads in engine thread factory

@sgammon sgammon added enhancement New feature or request 🚧 WIP Works-in-progress. Blocks merge labels Oct 5, 2023
@sgammon sgammon self-assigned this Oct 5, 2023
@sgammon sgammon mentioned this pull request Oct 5, 2023
42 tasks
Copy link
Member Author

@sgammon sgammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here...

@@ -69,7 +69,7 @@ import org.graalvm.polyglot.Engine as VMEngine
AutoCloseable,
ToolCommandBase<Context>() {
protected companion object {
private const val enableVirtualThreads = false
private const val enableVirtualThreads = true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... we ...

Comment on lines +19 to +25
type: VIRTUAL
io:
threads: 2
type: VIRTUAL
scheduled:
threads: 1
type: VIRTUAL
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... go!

@sgammon sgammon removed the 🚧 WIP Works-in-progress. Blocks merge label Oct 5, 2023
@sgammon sgammon marked this pull request as ready for review October 5, 2023 05:47
Base automatically changed from alpha7/hotfixes to release/alpha7 October 5, 2023 05:50
- feat: enable `VIRTUAL` threads in micronaut executors
- feat: enable `ofVirtual` threads in engine thread factory

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon merged commit 2fc0aa5 into release/alpha7 Oct 5, 2023
12 checks passed
@sgammon sgammon deleted the alpha7/sicko-mode branch October 5, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant