Catching an exception on Send. This happens when request for HEAD ret…

[rybama]

…urns 405 Method Not Allowed. Instead of error http status, this may throw an exception. Return false and fallback to link download.

[jimmywarting]

In which browser dose it throw an error?
i only get a error log.

the code still runs after it (also tried it without the onerror - same result)

seems like this PR in unnecessary

[rybama]

I'm gettin exception (NetworkError) on Chrome and Firefox for some reason. I'm not sure here, but could it be the case that HEAD method is not implemented on the API and thus causing the exception?

[jimmywarting]

Mind sharing the url you are trying so that i can test it?
also dose it throw with the httpbin url i used?

[rybama]

httpbin url you send doesn't throw an exception. This api endpoint for example will throw an exception https://portal.radar.f-secure.com/api/latest/productinfo (works for GET, not HEAD). I'm now more convinced that send throws an exception when certain API doesn't implement HEAD verb.

[jimmywarting]

hmm, when making a sync request to any url that don't implement CORS support seems to throw an error

[rybama]

So, is it good to merge it?

[rybama]

@jimmywarting kindly reminder :) ping :)

[rybama]

@jimmywarting I would like to ask to for clear comment if you intend to accept this change or not. We rely on the forked project in the npm dependencies in our project right now which I would like to remove.

[jimmywarting]

Sure. Will try to do it later todayy

[jimmywarting]

released this with v2.0.2 on npm now

[rybama]

thanks!

[xiaoluntian]

hi why use a HEAD request,not the GET request replace.If crosed enabled,continue to use blob to download, if not, go to the other side.