-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable autopxd to use Microsoft Visual C++ for preprocessing on Windows #40
Conversation
I'm publishing this as a draft, because I may not get time to finish it up, but wanted to share the work in case someone else can pick it up. Basically, I wanted this to work without installing MinGW or some other build of GCC, so I added handling for when then In case you've never seen it before, the VS discovery is how it's supposed to work. There are no suitable registry entries for VS anymore, and the vswhere tool is always in the same location. It does, however, need better handling for when the tool is missing. If the tool is missing, there are no VS installs, which would be an error here anyway! But the error message could be better - similarly if the returned JSON is an empty list (i.e. no VS install included Also tests, of course, though it appears you don't have Windows CI set up anyway. It seems to work okay anyway though 👍 |
I just rebased and squashed everything as there's nothing interesting in my history. I wish the Windows tests could be quicker - they are embarrassingly slow. It's just the nature of launching processes on Windows. That's the big heavy process, and because it keeps shelling out to MSVC or GCC multiple times, it's inherently slow. If you'd rather not have the tests run on every PR, I understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for contributing. I don't have Windows to test these changes with and am unfamiliar with the stack, so just have a few clarifying questions.
Co-authored-by: Elijah <elijahr@gmail.com>
This is great. Really appreciate it! Will publish a new release with these changes soon. |
This has been released in v2.2.2. |
Thanks Steve! 🙏 Nice to see Windows support here 😄 |
No description provided.