Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP-1596: Changes dockerfile to use our fork #1

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

hankwallace
Copy link

@hankwallace hankwallace commented Jun 4, 2020

Changes the Dockerfile to use our fork of the open-source project.

The goal is to make the fewest changes possible to this, and the hapi-fhir, forked repos so that it will be easier to merge upstream changes from the open-source project.

The only reason to use our fork of the hapi-fhir repo instead of the open-source repo is to give us the option to patch it if needed and submit pull requests to the open-source project.

@hankwallace hankwallace merged commit f685c97 into master Jun 4, 2020
@hankwallace hankwallace deleted the use-fork branch June 4, 2020 18:05
@@ -1,8 +1,8 @@
FROM hapiproject/hapi:base as build-hapi

ARG HAPI_FHIR_URL=https://github.com/jamesagnew/hapi-fhir/
ARG HAPI_FHIR_URL=https://github.com/elimuinformatics/hapi-fhir.git
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .git on the end should not be needed.

shubhamparikh927 pushed a commit that referenced this pull request Feb 12, 2021
shubhamparikh927 pushed a commit that referenced this pull request Feb 12, 2021
hankwallace pushed a commit that referenced this pull request Jan 20, 2024
Fixing some typos in README.md
hankwallace pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants