Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default per_page value #7

Merged
merged 1 commit into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Concerns/Users.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ trait Users
{
public function getUsers(
?int $companyId = null,
int $perPage = 30,
int $perPage = 100,
int $page = 1
): Response {
return $this->get('users/minimal', [
Expand Down
2 changes: 1 addition & 1 deletion src/Facades/RepCard.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
* @method static \Illuminate\Http\Client\Response getLeaderboards(\DateTimeInterface|string|null $from = null, \DateTimeInterface|string|null $to = null)
* @method static \Illuminate\Http\Client\Response getOffices(string|null $search = null)
* @method static \Illuminate\Http\Client\Response getOfficeTeams(int $officeId)
* @method static \Illuminate\Http\Client\Response getUsers(int|null $companyId = null, int $perPage = 30, int $page = 1)
* @method static \Illuminate\Http\Client\Response getUsers(int|null $companyId = null, int $perPage = 100, int $page = 1)
* @method static \Illuminate\Http\Client\Response getUser(int $userId)
* @method static \Illuminate\Http\Client\Response getEventUser(int $userId)
* @method static \Illuminate\Http\Client\Response createUser(\RepCard\Http\Requests\UserRequest $request)
Expand Down
2 changes: 1 addition & 1 deletion tests/Facades/RepCardTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public function test_get_users(): void

RepCard::fake('/users/minimal', $query = [
'company_id' => $companyId,
'per_page' => 30,
'per_page' => 100,
'page' => 1,
]);

Expand Down
Loading