Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 10173: save criteria and duplicates #1

Closed
wants to merge 7 commits into from

Conversation

eliserichards
Copy link
Owner

@eliserichards eliserichards commented May 28, 2020

For mozilla-mobile#10173

  • make call to AC to get dupes list
    • need some review on the async coroutines calls
  • pass list to fragment (from the controller?)
  • always check username edits against dupe list
  • have a global "save enabled" state
    • set this on any text change?
    • ensure that username & password aren't overriding saveEnabled when they shouldn't be (e.g., username is invalid and saveEnabled = false, but you click on pwd and edit to a valid state. saveEnabled shouldn't be set to true on password edit)
  • Tests!
  • keyboard clicks to show/hide

@eliserichards eliserichards force-pushed the 10173-login-duplicates branch from 16dcf0b to 2e84b3c Compare June 9, 2020 18:22
eliserichards pushed a commit that referenced this pull request May 19, 2021
Merging changes from Master to My Fenix branch 4/19/21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant