-
Notifications
You must be signed in to change notification settings - Fork 12
Add Source Code Pro font family for better rendering of powerline symbols #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @matthewstrasiotto ! Am I missing something? On my end it looks like in the screenshot bellow, and the spacing is way too big.
If it's supposed to look like this, and it's not just some problem on my end with the build (🤔), then I would not like to have this as the default font - instead it should be a config on the client/frontend side, where the user can choose the SourceCodePro font if they want.
That looks munted. I'll run my own build, but that's not a normal effect of the font. You could try commenting my changes in the js & cleaning/rebuilding the frontend/project, to see what happens Also, source code pro isn't the only way to get powerline symbols, i think I've seen people combine powerline fonts w/ whatever monospace they're keen on |
This comment has been minimized.
This comment has been minimized.
I think the default font is courier new. |
@elisescu the reason the appearance was way off was that the css styles I'd given were first resolving locally installed fonts (systemwide), then falling back to a URL, but I think I messed up the URL, maybe? So on my machine they used my local fonts, and worked well, but you don't have them installed & the fallback didn't work. I'm fixing this now |
Something isnt quite commuting about serving up the fonts. They appear to be getting bundled to public and assete_bundle.go too, but I cant see them with the inspector. I could probably revert to how i had it, where it attempts to use local fonts, but extend it to fracefully degrade to a websafe font , but i want it to feel more portable than that and less system dependent |
This reverts commit 51f1894. This is because I don't want this diff in the squash just yet
@elisescu this is ready to merge (preferably squashed, unfortunately it involved a lot of trial & error), though assets_bundle.go hasn't been regenned, I'd prefer that be done after merging. One npm dependency was added, I'm going to submit a new PR on a clean branch |
Resolves #9 , please wait until I can remove the vagrantfile & feel free to squash this