Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: relax dependency version constraints #202

Closed
uniqueg opened this issue Jan 22, 2024 · 0 comments · Fixed by #228
Closed

build: relax dependency version constraints #202

uniqueg opened this issue Jan 22, 2024 · 0 comments · Fixed by #228
Milestone

Comments

@uniqueg
Copy link
Member

uniqueg commented Jan 22, 2024

Problem

Currently, the versions of most dependencies are pinned to a precise version. This means that everytime a pinned version gets deprecated, removed etc, all apps relying on FOCA stop working.

Solution

Relax dependency version limits such that any compatible version with the currently pinned ones can be used. E.g., if a version is pinned to 1.2.3, then any version that fulfills >= 1.2.3, < 2 should be permitted.

For any minor dependencies that likely would not stop FOCA from working if updated to a new major version, we can also remove the < part.

I would suggest, as a starting point, to only prevent new major versions from the following packages:

  • celery <6
  • connexion <3
  • Flask <3
  • Flask-PyMongo <3
  • pydantic <2
  • pymongo <4
  • Werkzeug <3

All the rest, just >= currently pinned version should probably/hopefully work just fine.

@uniqueg uniqueg modified the milestones: v0.13.0, v1.0.0 Jan 22, 2024
@uniqueg uniqueg moved this to Todo other in FOCA release Jan 22, 2024
@uniqueg uniqueg changed the title build: relax dependency version limits build: relax dependency version constraints May 20, 2024
@github-project-automation github-project-automation bot moved this from Todo other to Done in FOCA release May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant