Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make project PEP 561 compliant #190

Closed
wants to merge 1 commit into from
Closed

build: make project PEP 561 compliant #190

wants to merge 1 commit into from

Conversation

Rahuljagwani
Copy link
Contributor

Description

Fixes #187

STEPS:

  1. Created py.typed file in the root directory.
  2. Mentioned the same in setup.py

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (or documentation does not need to be updated)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

@Rahuljagwani
Copy link
Contributor Author

Hi @uniqueg,

Can you review this??

@Rahuljagwani Rahuljagwani deleted the pep561-compliant branch December 8, 2023 08:51
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @Rahuljagwani. Why did you close the PR?

@uniqueg
Copy link
Member

uniqueg commented Dec 8, 2023

Well, except for the linting error. If you run black on setup.py, commit and push, that should fix it. Or otherwise manually wrap the package_data dictionary argument so that it doesn't exceed the line length.

@Rahuljagwani
Copy link
Contributor Author

Well, except for the linting error. If you run black on setup.py, commit and push, that should fix it. Or otherwise manually wrap the package_data dictionary argument so that it doesn't exceed the line length.

Thanks @uniqueg, I figured out the error. I have opened a new PR #191.

@uniqueg
Copy link
Member

uniqueg commented Dec 8, 2023

Oh, you could have just pushed to the same branch and the PR would have been updated. But no worries, we'll use the new PR then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: make project PEP 561 compliant
2 participants