Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make project PEP 561 compliant #192

Closed

Conversation

Rahuljagwani
Copy link
Contributor

Description

Fixes #187

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (or documentation does not need to be updated)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

@Rahuljagwani Rahuljagwani requested a review from uniqueg December 8, 2023 11:40
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c89ba8) 100.00% compared to head (61d754a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          984       984           
=========================================
  Hits           984       984           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rahuljagwani
Copy link
Contributor Author

I am not able to get it. When I pushed the commit, the pet store tests failed as one of the statements was DOCKERHUB_ORG: . But in other PR tests, the same statement comes as: DOCKERHUB_ORG: ***. Link.
Am I doing something wrong?
@uniqueg

@uniqueg
Copy link
Member

uniqueg commented Dec 8, 2023

You still created the pull request from your fork.

Instead, what you should do is:

  1. Clone the repo and move inside the directory:
    git clone https://github.com/elixir-cloud-aai/foca.git
    cd foca
  2. Then create a "feature branch" with:
    git checkout -b "pep561"
  3. Apply your changes.
  4. Stage files, commit and push:
    git add setup.py py.typed
    git commit -m "build: make project PEP 561 compliant"
    git push origin pep561
  5. Finally, come back to the repo and create a new pull request.

@uniqueg uniqueg closed this Dec 8, 2023
@Rahuljagwani
Copy link
Contributor Author

You still created the pull request from your fork.

Instead, what you should do is:

  1. Clone the repo and move inside the directory:
    git clone https://github.com/elixir-cloud-aai/foca.git
    cd foca
  2. Then create a "feature branch" with:
    git checkout -b "pep561"
  3. Apply your changes.
  4. Stage files, commit and push:
    git add setup.py py.typed
    git commit -m "build: make project PEP 561 compliant"
    git push origin pep561
  5. Finally, come back to the repo and create a new pull request.

Thanks a lot @uniqueg, created PR #193 (finally all checks have passed).
Do we need to mention the above steps in developer documentation or CONTRIBUTING.md for new contributors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: make project PEP 561 compliant
2 participants