Make checkout/3 overridable in adapters #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
|
DBConnection should not be required, so any changes that remove that decoupling is welcome. You will likely need it for |
|
We just always return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exandra (a Cassandra/Scylla adapter for Ecto) uses
Xandra.Clusterunderneath. The issue arises because aXandra.Clusterprocess is not a db_connection pool. That's because it has to connect to multiple nodes in a cluster, have a lot of logic to decide which node to execute each query on, and so on. Anyway, this causes issues with Ecto because the defaultcheckout/3implementation (injected throughuse Ecto.Adapters.SQL) relies on the db_connection behavior. This PR simply makes that callback overridable, which in our case means that we can use the cluster's logic to check out a connection.Thoughts? 🙃
cc @vinniefranco