Add --log-level to ecto.migrate and ecto.rollback #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
reviewed
Jul 27, 2023
wojtekmach
reviewed
Jul 27, 2023
josevalim
reviewed
Jul 27, 2023
lib/mix/tasks/ecto.rollback.ex
Outdated
| @@ -117,6 +124,9 @@ defmodule Mix.Tasks.Ecto.Rollback do | |||
| do: Keyword.merge(opts, log: false, log_migrations_sql: false, log_migrator_sql: false), | |||
| else: opts | |||
|
|
|||
| log_level = String.to_existing_atom(Keyword.get(opts, :log_level, "debug")) | |||
There was a problem hiding this comment.
I think we should do it conditionally, as above, in case the user does call it after their application is started.
josevalim
reviewed
Jul 27, 2023
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do support the
:logoption, but that's only for things that Ecto itself logs. If, for example, adapters log something at thedebuglevel (regardless of whether that's a good idea or not), then it'll get logged because we are not configuring the log level anywhere.cc @josevalim