-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elixir-format does not respect locals_without_parens in .formatter.exs #428
Comments
I know this is not the kind of answer that you expect but a way to make it work is not using the format functionality here... this is how I use format with the reformatter.el package: (use-package reformatter
:config
(reformatter-define +elixir-format
:program "mix"
:args '("format" "-"))
(defun +set-default-directory-to-mix-project-root (original-fun &rest args)
(if-let* ((mix-project-root (and buffer-file-name
(locate-dominating-file buffer-file-name
".formatter.exs"))))
(let ((default-directory mix-project-root))
(apply original-fun args))
(apply original-fun args)))
(advice-add '+elixir-format-region :around #'+set-default-directory-to-mix-project-root)
(add-hook 'elixir-mode-hook #'+elixir-format-on-save-mode)) |
Thanks, @victorolinasc! It may not be the answer that I was looking for but it's definitely a useful workaround for those who come across this issue in the future. I personally don't use Elixir much anymore so the issue is no longer important to me personally, but regardless I still feel this is an important issue with regards to |
Currently the `launch.sh` script will check for asdf in my home directory. As I am a Homebrew user, my asdf got installed to `/usr/local/opt/asdf`. For `launch.sh` to be able to detect it I've modified it for the use of `ASDF_DIR` if available and fall-back to the current behaviour if that's not set. asdf will set the [`ASDF_DIR` (see upstream source)][1] variable when it initializes, so this seems to be a reliable way to detect all sorts of customized asdf installations. [1]: https://github.com/asdf-vm/asdf/blob/master/asdf.sh#L14
With the following .formatter.exs and files,
mix format $file
respectslocals_without_parens
, whereas elixir-format does not.formatter.exs
lib/pea_bb/bbs/router.ex
lib/pea_bb/macro/route.ex
(I doubt the last file is important, but I included it for completeness sake given that these files have no external dependencies other than the existence of the modules being routed to)
when elixir-format is run,
lib/pea_bb/bbs/router.ex
is changed tothis is not the case for when
mix format
is runThe text was updated successfully, but these errors were encountered: