Include - in punctuation syntax class

[aaronjensen]

- is subtraction in elixir, not part of a symbol, though I may be missing something.

[gausby]

I guess - is a special form. I don't know if that count for anything.

[aaronjensen]

I'd say no, it's an operator first imo. Specifically it should not consider a-b to be a single symbol. It is two symbols separated by an operator.

[gausby]

I might be a schoolboy here, but what is the benefits to adding minus to the syntax table? I notice that other infix characters are not there, such as multiply, division, plus, etc.

[aaronjensen]

@gausby they're all in the syntax table and they're categorized as punctuation, like what I moved - to:

From the docs:

Syntax class: symbol constituent

Symbol constituents (designated with _') are the extra characters that are used in variable and command names along with word constituents. For example, the symbol constituents class is used in Lisp mode to indicate that certain characters may be part of symbol names even though they are not part of English words. These characters are$&*+-<>'. In standard C, the only non-word-constituent character that is valid in symbols is underscore (`').

Syntax class: punctuation character

Punctuation characters (`.') are those characters that are used as punctuation in English, or are used in some way in a programming language to separate symbols from one another. Most programming language modes, including Emacs Lisp mode, have no characters in this class since the few characters that are not symbol or word constituents all have other uses.

For a practical reason, this is kill-sexp with - as a symbol:

And as punctuation:

It would also apply to searching for a symbol under the point. In short, there's no actual reason I can come up with that - would be marked as a symbol other than forgetting to override it from the default syntax table.

[gausby]

Okay. Thanks for the explanation. I agree that it would be awesome.

On my machine (running the latest master of elixir-mode) I get the same behaviour for +, -, *, and / when running kill-sexp; I do think they are all symbols. Could be something with my setup…anyways, it seems that there are some issues with the unit tests after applying this change.

[aaronjensen]

@gausby ah, indeed, I think I was looking at the syntax table for ruby at the time. I updated the pull request to include all of those operators. I'm not sure about the unit tests, I'll see if they pass this time.

[aaronjensen]

Looks like the tests are still failing which is rather surprising. I'll see if I can get the tests running and figure out what's going on when i get a chance.

[aaronjensen]

@gausby I saw some conversation on #emacs-elixir, are these failures just intermittent ones or are they actual failures?

[gausby]

@aaronjensen it seems that they are actual errors: https://travis-ci.org/elixir-lang/emacs-elixir/jobs/130900904

[aaronjensen]

@gausby I was missing < and >, so it treated <- incorrectly I believe. All good now.

[tonini]

@aaronjensen great! thanks a lot guys 💛 💙 💚