Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove arg swap hack from Series.add #731

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Remove arg swap hack from Series.add #731

merged 2 commits into from
Nov 8, 2023

Conversation

billylanchantin
Copy link
Contributor

As part of #696, we introduced a hack where we swapped the arguments to Series.add since Polars only supported date + duration and not duration + date. This PR removes that hack since as of Polars 0.34, it's no longer needed:

@billylanchantin billylanchantin merged commit 1d5ad56 into main Nov 8, 2023
3 checks passed
@billylanchantin billylanchantin deleted the billy-remove-arg-swap-hack branch November 8, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billylanchantin @josevalim