Added Series.ewm_std/2 and Series.ewm_var/2 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Dec 17, 2023
lib/explorer/backend/lazy_series.ex
Outdated
| @@ -73,6 +73,8 @@ defmodule Explorer.Backend.LazySeries do | |||
| window_sum: 5, | |||
| window_standard_deviation: 5, | |||
| ewm_mean: 5, | |||
| ewm_std: 6, | |||
| ewm_var: 6, | |||
There was a problem hiding this comment.
We call these things variance and standard_deviation below. Should we rename these two to match them?
There was a problem hiding this comment.
The function names were copied as is from polars. We should rename to match the convention used in Explorer.
josevalim
reviewed
Dec 17, 2023
|
The functions have been renamed to |
josevalim
reviewed
Dec 17, 2023
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #776.