Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Series.concat/2 for null series #828

Merged
merged 3 commits into from
Jan 18, 2024
Merged

fix for Series.concat/2 for null series #828

merged 3 commits into from
Jan 18, 2024

Conversation

lkarthee
Copy link
Member 

1) test concat/1 concat null with {:s, 8} (Explorer.SeriesTest)
     test/explorer/series_test.exs:3866
     ** (RuntimeError) Polars Error: data types don't match: cannot extend/append Null with Int8
     code: sr = Series.concat([sn, s1])
     stacktrace:
       (explorer 0.8.0-dev) lib/explorer/polars_backend/shared.ex:17: Explorer.PolarsBackend.Shared.apply/2
       (explorer 0.8.0-dev) lib/explorer/polars_backend/series.ex:145: Explorer.PolarsBackend.Series.concat/1
       test/explorer/series_test.exs:3870: (test)

josevalim
josevalim reviewed Jan 18, 2024
View reviewed changes
lib/explorer/series.ex Outdated Show resolved Hide resolved
@josevalim josevalim merged commit 7646c45 into elixir-explorer:main Jan 18, 2024
3 checks passed
@josevalim
Copy link
Member

Great find, thank you! 💚 💙 💜 💛 ❤️

@lkarthee lkarthee deleted the series_concat_null_fix branch January 19, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkarthee @josevalim