Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eager Series.count/1 and lazy Series.size/1 #844

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Add eager Series.count/1 and lazy Series.size/1 #844

merged 3 commits into from
Feb 2, 2024

Conversation

billylanchantin
Copy link
Contributor

Closes

Changes

  • Adds an eager version of Series.count/1
  • Adds a lazy version of Series.size/1

Context

This helps address the breaking change to the count expression introduced by Polars Rust 0.36.2. That change made count ignore null values.

billylanchantin and others added 2 commits February 1, 2024 20:17
@billylanchantin @lkarthee
stay in elixir for count/1
77cbe56 
Co-authored-by: lkarthee <lkarthee@users.noreply.github.com>
@billylanchantin
remove s_count from polars
bacf703
philss
philss approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@billylanchantin billylanchantin merged commit c02f810 into main Feb 2, 2024
4 checks passed
@billylanchantin billylanchantin deleted the bl-count-and-len branch February 2, 2024 01:32
@billylanchantin billylanchantin mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkarthee lkarthee lkarthee left review comments

@philss philss philss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billylanchantin @philss @lkarthee