Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the start_server: true global config #246

Closed
polvalente opened this issue Jul 22, 2022 · 0 comments · Fixed by #258
Closed

Remove the start_server: true global config #246

polvalente opened this issue Jul 22, 2022 · 0 comments · Fixed by #258
Assignees
@polvalente
Labels
enhancement
Milestone
v0.6

Comments

@polvalente
Copy link
Contributor

We should avoid global application config because it makes things more difficult when a dependency also depends on the library an user wishes to use.

One such case is the config :grpc, :start_server, true key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polvalente polvalente

Labels
enhancement
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

refactor: change application config methods elixir-grpc/grpc
1 participant
@polvalente