refactor: revise route_guide example #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wingyplus
commented
Jul 22, 2022
wingyplus
commented
- Change supervisor declration in tree.
- Cleanup dependencies.
- Use jason instead of poison.
- Auto start server.
- Move route_guide.proto to priv/protos.
* Change supervisor declration in tree. * Cleanup dependencies. * Use jason instead of poison. * Auto start server. * Move route_guide.proto to priv/protos.
polvalente
reviewed
Jul 22, 2022
| @@ -1,3 +1,3 @@ | |||
| import Config | |||
|
|
|||
| # config :grpc, start_server: true | |||
| config :grpc, start_server: true | |||
There was a problem hiding this comment.
This is something I wish to refactor. IMO We should move to a "add X to your supervision tree" instead of this global config
There was a problem hiding this comment.
You means like:
children = [
{GRPC.Server.Supervisor, {Endpoint, 50000}, start_server: true}
]
There was a problem hiding this comment.
Exactly! I've opened #246 for this
There was a problem hiding this comment.
This would enable multiple servers to run from the same application in different ports
There was a problem hiding this comment.
Great! I will change the example to use the new way after resolve #246 . 🙇♂️
polvalente
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.