Remove gun-specific code from stub to improve client adapter flexibility #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beligante
changed the title
polvalente
reviewed
Aug 30, 2022
polvalente
reviewed
Aug 30, 2022
polvalente
reviewed
Aug 30, 2022
polvalente
reviewed
Aug 30, 2022
polvalente
reviewed
Aug 30, 2022
polvalente
reviewed
Aug 30, 2022
polvalente
reviewed
Aug 30, 2022
Sweet! Tks for the review. I'll work on these comments on the weekend while I finish the work for the mint adapter |
Merged
beligante
changed the title
polvalente
reviewed
Oct 12, 2022
lib/grpc/client/adapters/gun.ex
Outdated
Comment on lines
139
to
142
| %{server_stream: true, channel: %{adapter_payload: adapter_payload}, payload: payload} = | ||
| stream, | ||
| opts | ||
| ) do |
There was a problem hiding this comment.
Let's split this match, leaving only the flow-control at the function head
Suggested change
| %{server_stream: true, channel: %{adapter_payload: adapter_payload}, payload: payload} = | |
| stream, | |
| opts | |
| ) do | |
| %{server_stream: true} = stream, | |
| opts | |
| ) do |
And then match to extract the data below. Same for the other clause
polvalente
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on this issue: #242
And while working on that, I've found that
stub.exhas a lot ofgunspecific code and that should live inside the adapter.This doesn't contains drastic code changes, I'm simply moving a small piece of code around to keep on working on adapter code.
My Idea here is to create an layer of abstraction, where each adapter implements it's own version of receiving data. For
gunwe have the mechanics of receive the headers first and then the payload.When working with Mint that's not the case. See
stream/2docsTL;DR: The message we receive in the process might contain headers and parts of the payload (in the same message). So having a function that receives the headers and the body doesn't make to much sense.